[c2pa-wc] Fix floating-ui build issue #106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emensch
force-pushed
the
main
branch
2 times, most recently
from
f0bbd4e to
d61dff1
Compare
|
I am having the same issue, but I while using the CDN for my vanilla setup with no builds or frameworks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
I was not able to use
cai-manifest-summarydue to an issue indist/components/Popover/Popover.js. This issue was caused by leftoverprocess.env.NODE_ENVchecks being run by the browser, which doesn't knowprocess. This is a known issue (one, two) caused by a dependency,@floating-ui/dom.This PR uses a fix recommended in the linked issues. I wasn't able to find an approriate variable indicating prod or dev env, so I have hardcoded it to
production.Types of changes
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment